Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Nametags are visible when invisible #219

Open
2 tasks done
Zezacle opened this issue Nov 25, 2024 · 1 comment
Open
2 tasks done

[bug] Nametags are visible when invisible #219

Zezacle opened this issue Nov 25, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@Zezacle
Copy link

Zezacle commented Nov 25, 2024

Are you using the latest available version for your server?

  • I am using the latest available version of fuji for my minecraft server.

Is there an existing issue for this?

  • I have searched the existing issues.

Current Behavior

Nametag renders regardless of player effects.

Expected Behavior

Nametag does not render when player has invisibility status effect.

Steps To Reproduce

Enable nametag module, go invisible

Server Logs

No response

Anything else?

No response

@Zezacle Zezacle added the bug Something isn't working label Nov 25, 2024
@Zezacle Zezacle changed the title [bug] Nametags are visible when invisible/spectator mode [bug] Nametags are visible when invisible Nov 26, 2024
@sakurawald
Copy link
Owner

sakurawald commented Nov 26, 2024

Hello, thanks for report.

You can think that the nametag is a display-text entity that riding on the player.

When another entity rides on a player, the player's nametag will be hidden, and instead, the entity's nametag will be displayed.

It can be a feature to hide the nametag if the player has in-visible effect.

In other words, the nametag is actually a display-text entity that rides on the player, its render logic is some bit different than the player's original nametag.

@sakurawald sakurawald added the enhancement New feature or request label Nov 26, 2024
@sakurawald sakurawald added the good first issue Good for newcomers label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants