Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more harmony characters and refactor view creation #32

Merged
merged 12 commits into from
Dec 21, 2024
Merged

Add more harmony characters and refactor view creation #32

merged 12 commits into from
Dec 21, 2024

Conversation

sakan811
Copy link
Owner

@sakan811 sakan811 commented Dec 21, 2024 •
edited
Loading

Description:

  • Add more harmony characters in harmony_main.py
  • Adjust ult_buff toughness reduction and add Yukong class.
  • Refactor toughness reduction into a reusable method.
  • Add function to generate dynamic damage view queries
  • Refactor view creation to use generated query.
  • Refactor view creation to use query generation.
  • Refactor view creation to use generated query.
  • Update disclaimers for Harmony character simulation details
  • Add Harmony simulation to main execution flow
  • Refactor Harmony character logic and expand class definitions.
  • Refactor view creation to use query generator.
  • Add Harmony character simulation and base class logic

@sakan811 sakan811 added the enhancement New feature or request label Dec 21, 2024
@sakan811 sakan811 enabled auto-merge December 21, 2024 12:05
@sakan811 sakan811 merged commit e0ebfb8 into master Dec 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sakan811