fix: update deprecated span processor

[saidsef]

• fix: update deprecated span processor

[saidsef]

/code pr

[saidsef]

🤖

Review of Modified Files

libs/index.mjs

• Line 102:

  • Original: tracerProvider.addSpanProcessor(spanProcessor);
  • Modified: tracerProvider.spanProcessor(spanProcessor);
  • Comment: The method name addSpanProcessor seems correct in context; changing it to spanProcessor might be incorrect unless new API changes exist. Ensure to verify the correct method usage from OpenTelemetry documentation.

• Lines 114-114 and beyond:

  • Original Order:

    new ExpressInstrumentation({ ignoreIncomingRequestHook, }),
    new PinoInstrumentation({ logHook: (span, record) => { record['resource.service.name'] = tracerProvider.resource.attributes['service.name']; }, }),
    new HttpInstrumentation({ requireParentforOutgoingSpans: false, requireParentforIncomingSpans: false, ignoreIncomingRequestHook, }),
    new ConnectInstrumentation(),
    new AwsInstrumentation({ sqsExtractContextPropagationFromPayload: true, }),
    

  • Modified Order: Swapped some of the instrumentation order.
  • Comment: Verify if the order of instrumentations impacts functionality or logic. The order can sometimes affect initialization sequencing or dependencies.

package-lock.json

• Version Increment:

  • Line 4:
    • Original: "version": "3.1.0",
    • Modified: "version": "3.2.0",
  • Comment: Ensure that semantic versioning conventions are followed. This implies backward-incompatible changes or new features have been added.

• Line 615 (Node Modules: @eslint/core):

  • Original: "version": "0.11.0",
  • Modified: "version": "0.12.0",
  • Comment: Verify that the newer version of @eslint/core is compatible with other ESLint packages. Ensure tests run successfully to confirm no breaking changes affect your environment.

• Line 628 (Node Modules: @eslint/eslintrc):

  • Original: "version": "3.2.0",
  • Modified: "version": "3.3.0",
  • Comment: Similar to the previous dependency, check for compatibility between ESLint related packages.

• Line 685 (Node Modules: @eslint/js):

  • Original: "version": "9.20.0",
  • Modified: "version": "9.21.0",
  • Comment: Ensure comprehensive tests to confirm no new ESLint features or changes cause issues in linting or configuration.

• Line 751 (Node Modules: @grpc/grpc-js):

  • Original: "version": "1.12.6",
  • Modified: "version": "1.12.7",
  • Comment: Verify that the newer version doesn't introduce compatibility issues or regressions in related code handling gRPC calls.

• Line 870 (Node Modules: @opentelemetry/instrumentation-aws-sdk):

  • Original: "version": "0.49.0",
  • Modified: "version": "0.49.1",
  • Comment: Ensure AWS SDK instrumentation functions correctly. Validate by testing instrumentation on AWS services to confirm monitoring as expected.

• Line 879 (Node Modules: @opentelemetry/instrumentation-connect):

  • Original: "version": "0.43.0",
  • Modified: "version": "0.43.1",
  • Comment: Confirm that the new version does not affect HTTP transport monitoring.

• Additional Dependency Version Updates:

  • Follow a similar verification routine for all other version updates within package-lock.json, verifying compatibility, functionality, and impact through existing tests.

General Recommendations:

• Run the full test suite to ensure these modifications do not break existing functionality.
• If certain changes lack sufficient documentation, consult recent official documentations or changelogs for the respective packages.
• Where possible, leave notes or documentation regarding the rationale for version increments to inform future developers.

Overall, while the modifications include dependency updates indicating potential new capabilities or patches, careful verification and testing are essential to safeguard functionality.

_{> microsoft/phi-4 [pr | 2]}

[saidsef]

/code pr

[saidsef]

🤖
libs/index.mjs:
• Replacing addSpanProcessor() with spanProcessor() is the sole functional change here. Please confirm that tracerProvider.spanProcessor() is correct per the latest API.
• The reordering and inline formatting of the instrumentation array is cosmetic; ensure the intended order does not affect initialisation.

package-lock.json & package.json:
• Version bumps across packages (including eslint-related modules, OpenTelemetry instrumentations, and others) have been implemented. Verify that these new versions are compatible with your codebase and that no breaking changes have been introduced.

Overall, the changes are clear and primarily focused on dependency updates and minor API adjustments.

_{> o3-mini [pr | 2]}