Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add TF 1.7 to ci workflow #28

Merged
merged 1 commit into from
Jun 21, 2024
Merged

chore: add TF 1.7 to ci workflow #28

merged 1 commit into from
Jun 21, 2024

Conversation

saidsef
Copy link
Owner

@saidsef saidsef commented Jun 21, 2024

No description provided.

@saidsef saidsef added the enhancement New feature or request label Jun 21, 2024
@saidsef saidsef self-assigned this Jun 21, 2024
@saidsef
Copy link
Owner Author

saidsef commented Jun 21, 2024

/code pr

Copy link
Owner Author

@saidsef saidsef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

Review Comments

.github/workflows/ci.yaml

  • Line 7: Good addition of Terraform 1.7 to the matrix. This ensures compatibility testing with the new version.
  • Enhancement: Consider adding a comment to explain the inclusion of each version for future maintainers. Example:
    # Adding Terraform versions to ensure compatibility across multiple releases

.github/workflows/tfsec.yaml

  • Line 7: Changing terraform_version to latest is a good practice to always use the most recent stable version. However, this might introduce breaking changes if a new version has incompatible updates.
  • Enhancement: It might be safer to pin to a specific version or use a range to avoid unexpected issues. Example:
    terraform_version: ">= 1.5, < 2.0"

Summary

  • The changes are straightforward and improve the CI workflow by adding support for Terraform 1.7.
  • Consider adding comments for clarity and using version ranges for stability.

> gpt-4o [pr | 2]

@saidsef saidsef merged commit 4556b5b into main Jun 21, 2024
14 checks passed
@saidsef saidsef deleted the ci-1-7 branch June 21, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant