Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add overrides defaults to tempo config map #138

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

saidsef
Copy link
Owner

@saidsef saidsef commented Feb 14, 2025

  • fix: add overrides defaults to tempo config map

@saidsef saidsef added the enhancement New feature or request label Feb 14, 2025
@saidsef saidsef self-assigned this Feb 14, 2025
@saidsef
Copy link
Owner Author

saidsef commented Feb 14, 2025

/code pr

Copy link
Owner Author

@saidsef saidsef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖
Here are the suggested enhancements for the changes:

deployment/grafana/cm.yml:

  • The time shift values for tracesToLogsV2 could potentially be too large at ±1 hour. Consider reducing to smaller values like ±15m to avoid excessive log scanning:
spanStartTimeShift: '-15m'
spanEndTimeShift: '15m'

deployment/tempo/cm.yml:

  • When enabling service-graphs and span-metrics processors, consider adding rate limiting to prevent excessive resource usage:
defaults:
  metrics_generator:
    processors: [service-graphs, span-metrics]
    generate_native_histograms: both
    processor_service_graphs_max_items: 1000   # Add rate limiting
    processor_span_metrics_dimensions: ["service", "operation"]  # Limit dimensions

> claude-3-5-sonnet-latest [pr | 1]

github-actions[bot]
github-actions bot previously approved these changes Feb 14, 2025
@saidsef saidsef merged commit 757fbfa into main Feb 14, 2025
4 of 5 checks passed
@saidsef saidsef deleted the tempo-cm-trace branch February 14, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant