GAP 4.13.1 #38804
Open
GAP 4.13.1 #38804
+268
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlitzky
requested review from
kiwifb,
dimpase,
tornaria,
antonio-rojas and
enriqueartal
In gap 4.13 there are some improvements, e.g. converting fp groups to permutation groups, computing abelianization of fp groups, which lead to different generators. This commit fixes doctests so they pass using gap 4.13.
…ests Co-authored-by: Max Horn <max@quendi.de>
…ose test suite is disabled
…ced to dummy from list of packages whose test suite is disabled
There are a few simplicial set tests that require the polenta package with gap-4.13.x. We declare a new feature to support the corresponding "needs" tag.
…ackage Three tests in this file need the GAP package "polenta" to be installed; otherwise, the output (although perhaps not _wrong_) is not quite what we expect.
Fixes gap-system/gap#5796 This is the patch I'm using on Gentoo, it combines the upstream fix and one of its dependencies (without which the desired fix does not apply). Without it, you'll get some test failures with gap-4.13.x when GRAPE happens to be installed.
I've left the upper bound in there, but set to "5.0.0" which should have no real effect. But if 4.14.0 comes out and breaks somes tests, it's a lot easier to tweak the existing upper bound than it is to add one (again) and reindent everything.
|
Locally, I've still got the The CI is unhappy about the upgrade path, but I'm not sure why exactly. This is the failure... it looks like sagelib wasn't rebuilt after GAP was upgraded. The |
|
I tried to remove Tomorrow I'll test the SPKG upgrade path myself. |
It's not proprietary: you can either attach your runner to GitHub CI, or run tests fully locally: https://nektosact.com/ (you'd need Docker and go installed, though) |
|
For what it is worth in a test installation of Fedora 40, with this branch using spkg gap and installing gap_packages and sirocco, no gap-related test fails. |
|
|
|
If I understand correctly, in several local installation the branch is successful, but not in CI, because some files are not rebuilt. What can be done to make possible a positive review? |
Some tweak to the makefile spaghetti is required to force a rebuild of sagelib (specifically, any extensions linked to libgap) when GAP is updated. Or as a workaround, we might touch a bunch of files to trigger said rebuild, and leave this bug for the next sucker who tries to upgrade GAP. |
|
Documentation preview for this PR (built with commit 5d29ef2; changes) is ready! 🎉 |
Force these consumers of libgap to be rebuilt after the recent GAP upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to:
build/pkgs/gap: Update to 4.13.1, require >= 4.13 #38169With the four additional work items I mentioned in a comment on the latter:
# needs gap_package_polentaLet's see what the CI has to say...