Update gperftools integration for python3/musl #38675
Open
+3
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 7c161ed; changes) is ready! 🎉 |
C functions take bytes, not python strings. Without this, the profiler tries to write to "/", fails, and proceeds to do very little.
When the profiler is starting, this module goes to a lot of trouble to do... exactly what cysignals is designed to do. And cysignals does not fail on musl. So let's use cysignals instead?
orlitzky
force-pushed
the
gperftools-updates
branch
from
7236569
to
7c161ed
Compare
|
@fchapoton can I interest you in one last python2 -> python3 update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update this module for python3, and then fix #33047 by using cysignals instead of trying to guess the name of my libc.