You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
4. Keep PRs as small as possible. For each of your PR, you create one branch based on the latest master. Chain them if needed (base PR on other PRs). Here are sample steps you can follow. You can get more details about the workflow from [here](https://gist.github.com/Chaser324/ce0505fbed06b947d962).
26
+
```console
27
+
$ git checkout master
28
+
$ git remote update
29
+
$ git merge upstream/master
30
+
$ git checkout -b <your_branch_for_new_pr>
31
+
$ make build
32
+
$ <Iterate your development>
33
+
$ git push origin <your_branch_for_new_pr>
34
+
```
35
+
5. If you don't have a live object store ready add these envvars to skip tests for these:
15
36
- THANOS_SKIP_GCS_TESTS to skip GCS tests.
16
37
- THANOS_SKIP_S3_AWS_TESTS to skip AWS tests.
17
38
18
39
If you skip both of these, the store specific tests will be run against memory object storage only.
19
40
CI runs GCS and inmem tests only for now. Not having these variables will produce auth errors against GCS or AWS tests.
20
41
21
-
5. If your change affects users (adds or removes feature) consider adding the item to [CHANGELOG](CHANGELOG.md)
22
-
6. You may merge the Pull Request in once you have the sign-off of at least one developers with write access, or if you
42
+
6. If your change affects users (adds or removes feature) consider adding the item to [CHANGELOG](CHANGELOG.md)
43
+
7. You may merge the Pull Request in once you have the sign-off of at least one developers with write access, or if you
23
44
do not have permission to do that, you may request the second reviewer to merge it for you.
24
-
7. If you feel like your PR waits too long for a review, feel free to ping [`#thanos-dev`](https://join.slack.com/t/improbable-eng/shared_invite/enQtMzQ1ODcyMzQ5MjM4LWY5ZWZmNGM2ODc5MmViNmQ3ZTA3ZTY3NzQwOTBlMTkzZmIxZTIxODk0OWU3YjZhNWVlNDU3MDlkZGViZjhkMjc) channel on our slack for review!
45
+
8. If you feel like your PR waits too long for a review, feel free to ping [`#thanos-dev`](https://join.slack.com/t/improbable-eng/shared_invite/enQtMzQ1ODcyMzQ5MjM4LWY5ZWZmNGM2ODc5MmViNmQ3ZTA3ZTY3NzQwOTBlMTkzZmIxZTIxODk0OWU3YjZhNWVlNDU3MDlkZGViZjhkMjc) channel on our slack for review!
0 commit comments