Rename Store component's tsdb.path -> data-dir. (thanos-io#503)

Author: tgxworld

cmd/thanos/store.go

@@ -28,7 +28,7 @@ func registerStore(m map[string]setupFunc, app *kingpin.Application, name string
 
 	grpcBindAddr, httpBindAddr, newPeerFn := regCommonServerFlags(cmd)
 
-	dataDir := cmd.Flag("tsdb.path", "Data directory of TSDB.").
+	dataDir := cmd.Flag("data-dir", "Data directory in which to cache remote blocks.").
 		Default("./data").String()
 
 	gcsBucket := cmd.Flag("gcs.bucket", "Google Cloud Storage bucket name for stored blocks. If empty sidecar won't store any block inside Google Cloud Storage.").

docs/components/store.md

@@ -80,7 +80,7 @@ Flags:
                                 configurations. Sets of configurations
                                 accounting the latency differences between
                                 network types: local, lan, wan.
-      --tsdb.path="./data"      Data directory of TSDB.
+      --data-dir="./data"       Data directory in which to cache remote blocks.
       --gcs.bucket=<bucket>     Google Cloud Storage bucket name for stored
                                 blocks. If empty sidecar won't store any block
                                 inside Google Cloud Storage.

docs/getting_started.md

@@ -30,7 +30,7 @@ Thanos integrates with existing Prometheus servers through a sidecar process, wh
 
 The sidecar is responsible for backing up data into an object storage bucket and providing querying access to the underlying Prometheus instance for other Thanos components.
 
-### Backups 
+### Backups
 
 The following configures the sidecar to backup data into a Google Cloud Storage bucket.
 
@@ -199,7 +199,7 @@ Just like sidecars and query nodes, the store gateway joins the gossip cluster a
 
 ```
 thanos store \
-    --tsdb.path                 /var/thanos/store \     # Disk space for local caches
+    --data-dir                  /var/thanos/store \     # Disk space for local caches
     --gcs.bucket                example-bucket \        # Bucket to fetch data from
     --cluster.address           0.0.0.0:19891 \
     --cluster.advertise-address 127.0.0.1:19891 \

kube/manifests/thanos-store.yaml

@@ -28,7 +28,7 @@ spec:
         args:
         - "store"
         - "--log.level=debug"
-        - "--tsdb.path=/var/thanos/store"
+        - "--data-dir=/var/thanos/store"
         - "--cluster.peers=thanos-peers.default.svc.cluster.local:10900"
         # NOTE: This is required to be added in GCS prior startup of this.
         - "--gcs.bucket=<bucket-name>"

scripts/quickstart.sh

@@ -103,7 +103,7 @@ then
     --log.level debug \
     --grpc-address              0.0.0.0:19691 \
     --http-address              0.0.0.0:19791 \
-    --tsdb.path                 data/store \
+    --data-dir                  data/store \
     --gcs.bucket                "${GCS_BUCKET}" \
     --cluster.address           0.0.0.0:19891 \
     --cluster.advertise-address 127.0.0.1:19891 \