Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #494: Added descriptive placeholder text for Select dropdown #496

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fixed #494: Added descriptive placeholder text for Select dropdown #496

merged 1 commit into from
Nov 12, 2024

Conversation

myth293
Copy link

@myth293 myth293 commented Nov 8, 2024

Title : Dropdowns should have a more descriptive placeholder text

Issue No. : 494

Code Stack : React

Close #494

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have created a helpful and easy to understand README.md
  • [] I have updated the Index.html file for my contribution

@netlify Netlify
Copy link

netlify bot commented Nov 8, 2024 •
edited
Loading

✅ Deploy Preview for frontend-mini-challenges ready!

Name Link
🔨 Latest commit 301b4a0
🔍 Latest deploy log https://app.netlify.com/sites/frontend-mini-challenges/deploys/672e7e6d29aec40007538bc7
😎 Deploy Preview https://deploy-preview-496--frontend-mini-challenges.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

FrozenHearth
FrozenHearth approved these changes Nov 11, 2024
View reviewed changes
Copy link

@FrozenHearth FrozenHearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadanandpai sadanandpai merged commit 453b083 into sadanandpai:main Nov 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrozenHearth FrozenHearth FrozenHearth approved these changes

@sadanandpai sadanandpai sadanandpai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropdowns should have a more descriptive placeholder text
3 participants
@myth293 @sadanandpai @FrozenHearth