Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#468 fixed the dark mode color to blue #473

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

replyre
Copy link
Contributor

@replyre replyre commented Jul 20, 2024

Title and Issue number

Title : fixed the dark mode color to blue

Issue No. : #468

Code Stack : CSS

Close #<issue_no>

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have created a helpful and easy to understand README.md
  • [] I have updated the Index.html file for my contribution

Copy link

netlify bot commented Jul 20, 2024

Deploy Preview for frontend-mini-challenges ready!

Name Link
🔨 Latest commit 846acb8
🔍 Latest deploy log https://app.netlify.com/sites/frontend-mini-challenges/deploys/669da94f1f1b8a00080b2831
😎 Deploy Preview https://deploy-preview-473--frontend-mini-challenges.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@replyre
Copy link
Contributor Author

replyre commented Jul 20, 2024

hello @sadanandpai, i have done the required changes, please merge it.
here is the Screenshort for the same.

Screenshot (487)

Copy link
Owner

@sadanandpai sadanandpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Visibility is not good in light mode. We can have text in white there as well

@replyre
Copy link
Contributor Author

replyre commented Jul 22, 2024

hello @sadanandpai, sorry I forgot to check the changes in light mode as well.
I have made the required changes do look and let me know if more changes are required.

@sadanandpai sadanandpai merged commit e81d067 into sadanandpai:main Jul 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants