fix: #464 use session to store search filter #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frontend-mini-challenges ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@sadanandpai I believe we would need a clear-filters button after this. |
sadanandpai
requested changes
Jul 18, 2024
| selectedChallengesByTags: [], | ||
| newChallenge: false, | ||
| }; | ||
| }; |
There was a problem hiding this comment.
if initialSearchFilters has no dependency on the component, can we not move everything to util
There was a problem hiding this comment.
Okay, I'll try.
sadanandpai
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title and Issue number
Title : Keep track of search filters while navigating between challenges
Issue No. : #464
Code Stack : JSX
Closes #464
Checklist: