Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[React/traffic-lights] Fix timer lag after switching tabs - closes #325 #327

Merged
merged 2 commits into from
Nov 5, 2023
Merged

[React/traffic-lights] Fix timer lag after switching tabs - closes #325 #327

merged 2 commits into from
Nov 5, 2023

Conversation

rishabhm05
Copy link
Contributor

@rishabhm05 rishabhm05 commented Nov 5, 2023 •
edited
Loading

Title and Issue number

Title :

Issue No: Close #325 Timer lags behind lights after switching tabs issue

Code Stack :

Close #<issue_no>

Checklist:

  • [] I have mentioned the issue number in my Pull Request.
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have created a helpful and easy to understand README.md
  • [] I have updated the Index.html file for my contribution

@netlify Netlify
Copy link

netlify bot commented Nov 5, 2023 •
edited
Loading

✅ Deploy Preview for preeminent-tapioca-4294b2 canceled.

Name Link
🔨 Latest commit c360f8c
🔍 Latest deploy log https://app.netlify.com/sites/preeminent-tapioca-4294b2/deploys/6547b74a5928d8000875663f

arpansaha13
arpansaha13 requested changes Nov 5, 2023
View reviewed changes
Copy link
Collaborator

@arpansaha13 arpansaha13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

On line 31, there are template strings inside style tag right?
Are template strings required in that place?
Check if it works the same without them. If not required then please remove.

@arpansaha13 arpansaha13 changed the title Timer lags behind lights after switching tabs issue is Fixed [React/traffic-lights] Fix timer lag after switching tabs - closes #325 Nov 5, 2023
@arpansaha13 arpansaha13 merged commit 945db7e into sadanandpai:main Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpansaha13 arpansaha13 arpansaha13 approved these changes

Assignees

@rishabhm05 rishabhm05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[React/traffic-lights]: Timer lags behind lights after switching tabs
2 participants
@rishabhm05 @arpansaha13