logo fix

sadanandpai · Nov 30, 2023 · 33e38b4 · 33e38b4
1 parent 5f4d217
commit 33e38b4
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 13 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -1,12 +1,12 @@
 ### Contribution Guide
 
 - Feel free to contribute to this repo by raising the **pull request**
-- Spelling mistakes, improvements to answers, code comments, rephrasing of questions, additional details, or similar contributions are highly appreciated.
+- Spelling mistakes, improvements to answers, code comments, rephrasing of questions, additional details, or similar contributions are accepted
 
 #### Challenge contribution
 
 - The repo encourages the addition of new challenges that have been developed and modified by you
-- __Copy-paste codes from other Repos are not accepted as of now__
+- **Copy-paste codes from other Repos are not accepted as of now**
 - Challenges can be built by referring to the concepts used in other codebases and YouTube but should be developed on your own
 
 #### Standards
@@ -19,28 +19,28 @@
 
 ##### Steps to Contribute JavaScript Challenge
 
-- The challenge should be added as a separate folder that should be named with the name of the challenge inside `/native/machine-coding/`
+- The challenge should be added as a separate folder that should be named with the name of the challenge inside `/apps/javascript/src/challenges/`
 - Challenge should have a minimum of index.html
 - Import navbar js file in the head `<script src="../../helpers/header.js" type="module"></script>`
 - JavaScript and CSS code if exists should have separate file[s]
-- Challenge should be added to the array of challenges `/native/helpers/challenges.js`
+- Challenge should be added to the array of challenges `/apps/javascript/src/helpers/challenges.js`
 - Do not introduce new font or modify the body styles
 - Box sizing is taken care and no need to add it
 
 ##### Steps to Contribute React Challenge
 
-- The challenge should be added as a separate folder that should be named with the name of the challenge inside `/react/src/machine-coding/`
+- The challenge should be added as a separate folder that should be named with the name of the challenge inside `/apps/react/src/challenges/`
 - Challenge should have a minimum of App.jsx / App.tsx
 - The App should be broken down into components, each having its own files.
 - CSS should strictly use **module CSS** to prevent pollution in the global space.
-- Challenge should be added to the array of challenges `/react/src/helpers/challenges.ts`
-- The component should be imported and added to their respective position in the array of challenges in `/react/src/pages/Challenge.tsx`
+- Challenge should be added to the array of challenges `/apps/react/src/helpers/challenges.ts`
+- The component should be imported and added to their respective position in the array of challenges in `/apps/react/src/pages/Challenge.tsx`
 
 ##### Steps to Contribute VueJs Challenge
 
-- The challenge should be added as a separate folder that should be named with the name of the challenge inside `/vue/src/machine-coding/`
+- The challenge should be added as a separate folder that should be named with the name of the challenge inside `/apps/vue/src/challenges/`
 - Challenge folder should have at least one `.vue` file
 - The solution should be broken down into components as per requirement
 - CSS should be strictly **scoped CSS** to prevent pollution in global space
-- The challenge should be added to its respective position in the array of challenges in `/vue/src/helpers/challenges.ts`
-- The component should be (statically) imported and added as a separate route in the `/vue/src/routes.ts` file.
+- The challenge should be added to its respective position in the array of challenges in `/apps/vue/src/helpers/challenges.ts`
+- The component should be (statically) imported and added as a separate route in the `/apps/vue/src/routes.ts` file.
diff --git a/apps/host/index.html b/apps/host/index.html
@@ -2,7 +2,11 @@
 <html lang="en">
   <head>
     <meta charset="UTF-8" />
-    <link rel="icon" type="image/svg+xml" href="/vite.svg" />
+    <link
+      rel="icon"
+      type="image/svg+xml"
+      href="https://github.com/sadanandpai/frontend-mini-challenges/raw/main/shared/assets/logo.svg"
+    />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Frontend Mini Challenges</title>
   </head>

diff --git a/apps/host/public/vite.svg b/apps/host/public/vite.svg
diff --git a/apps/react/index.html b/apps/react/index.html
@@ -2,7 +2,11 @@
 <html lang="en">
   <head>
     <meta charset="UTF-8" />
-    <link rel="icon" type="image/svg+xml" href="/vite.svg" />
+    <link
+      rel="icon"
+      type="image/svg+xml"
+      href="https://github.com/sadanandpai/frontend-mini-challenges/raw/main/shared/assets/logo.svg"
+    />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Frontend Mini Challenges</title>
     <meta name="title" content="React Mini Challenges" />