Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refer to benchmarks repo for gas reference #256

Open
smol-ninja opened this issue Feb 5, 2025 · 5 comments · May be fixed by #285
Open

Refer to benchmarks repo for gas reference #256

smol-ninja opened this issue Feb 5, 2025 · 5 comments · May be fixed by #285
Labels
effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. type: refactor Change that neither fixes a bug nor adds a feature. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@smol-ninja
Copy link
Member

smol-ninja commented Feb 5, 2025 •
edited
Loading

Repo

Pages

  1. https://docs.sablier.com/guides/lockup/gas-benchmarks
  2. https://docs.sablier.com/guides/flow/gas-benchmarks
  3. https://docs.sablier.com/concepts/lockup/stream-shapes
@smol-ninja smol-ninja added effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. type: refactor Change that neither fixes a bug nor adds a feature. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Feb 5, 2025
@smol-ninja smol-ninja changed the title Link to benchmarks repo for gas references Link to benchmarks repo for gas reference Feb 5, 2025
@smol-ninja smol-ninja changed the title Link to benchmarks repo for gas reference Refer to benchmarks repo for gas reference Feb 5, 2025
@Patrick-Ehimen
Copy link
Contributor

@smol-ninja not quite sure what needs to be done here

@smol-ninja
Copy link
Member Author

The references to the benchmark code on github points to the old URL. For example, https://github.com/sablier-labs/lockup/tree/release/benchmark should now be https://github.com/sablier-labs/benchmarks.

@Patrick-Ehimen
Copy link
Contributor

ok i get it now, however i get a 404 error when accessing https://github.com/sablier-labs/benchmarks

@smol-ninja
Copy link
Member Author

Sorry, it was marked as private. You should be able to see it now.

@Patrick-Ehimen
Copy link
Contributor

Patrick-Ehimen commented Mar 20, 2025 •
edited
Loading

got it, will work on it right-away

@Patrick-Ehimen Patrick-Ehimen linked a pull request Mar 20, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. type: refactor Change that neither fixes a bug nor adds a feature. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: updates references to the benchmark code. Patrick-Ehimen/docs
2 participants
@smol-ninja @Patrick-Ehimen