[FEATURE] Add RemoveAddLLrefForTCAdescrMethodCallRector #4471
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| */ | ||
| public function refactor(Node $node): ?Node | ||
| { | ||
| if (! $node instanceof StaticCall) { |
There was a problem hiding this comment.
this check is useless as this will always be the case because of the nodeTypes filter above
|
|
||
| if (! $this->nodeTypeResolver->isMethodStaticCallOrClassMethodObjectType( | ||
| $node, | ||
| new ObjectType(ExtensionManagementUtility::class) |
There was a problem hiding this comment.
Do not import class names from TYPO3. See other rules how it is done.
| return null; | ||
| } | ||
|
|
||
| return null; |
There was a problem hiding this comment.
return null does nothing and does not remove the node.
| use TYPO3\CMS\Core\Utility\ExtensionManagementUtility; | ||
| CODE_SAMPLE | ||
| ), | ||
|
|
|
|
||
| use TYPO3\CMS\Core\Utility\ExtensionManagementUtility; | ||
|
|
||
| defined('TYPO3') or die(); |
|
Please also link the corresponding issue to this rule in the commit message and in the future please use a new branch to keep your main branch clean, otherwise you have to hard reset it after a merge. |
Co-authored-by: Simon Schaufelberger <simonschaufi@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Can you please have a look at my comments? |
|
Hello @simonschaufi |
No description provided.