Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyFileUtil: Generics with GLib.Value #216

Merged
merged 1 commit into from
Oct 14, 2024
Merged

KeyFileUtil: Generics with GLib.Value #216

merged 1 commit into from
Oct 14, 2024

Conversation

ryonakano
Copy link
Owner

Generics does not seem to support string[] so use GLib.Value instead.

../src/Model/DesktopFile.vala:140.63-140.70: error: Arrays are not supported as generic type arguments
  140 |             string[]? categories = Util.KeyFileUtil.get_value<string[]> (keyfile_dirty, KeyFileDesktop.KEY_CATEGORIES, Util.KeyFileUtil.get_strv);
      |                                                               ^~~~~~~~
../src/Model/DesktopFile.vala:154.40-154.47: error: Arrays are not supported as generic type arguments
  154 |             Util.KeyFileUtil.set_value<string[]> (keyfile_dirty, KeyFileDesktop.KEY_CATEGORIES, categories, Util.KeyFileUtil.set_strv);
      |                                        ^~~~~~~~
../src/Model/DesktopFile.vala:163.61-163.68: error: Arrays are not supported as generic type arguments
  163 |             string[]? keywords = Util.KeyFileUtil.get_value<string[]> (keyfile_dirty, Util.KeyFileUtil.KEY_KEYWORDS, Util.KeyFileUtil.get_strv);
      |                                                             ^~~~~~~~
../src/Model/DesktopFile.vala:177.40-177.47: error: Arrays are not supported as generic type arguments
  177 |             Util.KeyFileUtil.set_value<string[]> (keyfile_dirty, Util.KeyFileUtil.KEY_KEYWORDS, keywords, Util.KeyFileUtil.set_strv);
      |                                        ^~~~~~~~
glib-2.0.vapi:35.1-35.18: error: The type `bool' doesn't declare a GValue take function
   35 | public struct bool {
      | ^~~~~~~~~~~~~~~~~~
Compilation failed: 5 error(s), 0 warning(s)
[2/15] Generating src/valadoc with a custom command
Succeeded - 0 warning(s)
ninja: build stopped: subcommand failed.

@ryonakano ryonakano merged commit c8660f1 into main Oct 14, 2024
5 checks passed
@ryonakano ryonakano deleted the keyfile-generic branch October 14, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant