Compare content of KeyFile in DesktopFile class & lessen disk access #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some methods in DesktopFile are just wrappers of KeyFile and not related to DesktopFile itself.
…are-keyfile Conflicts: src/Model/DesktopFile.vala
Conflicts: src/Model/DesktopFile.vala src/Util/KeyFileUtil.vala
Re-loading DesktopFileModel.files_list changes addresses of DesktopFile in the list and causes the app crash when continuing editing.
ryonakano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MainWindow is not obliged to keep instances of unsaved DesktopFile and saved DesktopFile. We just compare only the KeyFile in DesktopFile anyways, so make DesktopFile do that job instead.