Reform PowerlineExtra sizing #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just responding to reiterate my comment from the issue, in regards to triangle widths. |
[why] When patching the Symbols Only font we derive the baseline to baseline distance through abnormal means, so the check fails. [how] Set expected baseline to baseline value explicitely for the Symbols Only font. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] The Powerline extra glyph sizing is not really clear. [how] Make the triangulars 1 cell wide, as for example Iosevka also does. Make the Legos 2 cell wide with pa scaling to make them look nicer. Make the Hexagons 2 cells wide and keep their aspect ratio if possible. Make small and big Squares also 2 cell wide and keep their aspect ratio of possible. For the small and big Squares add a tiny bit of border (negative overlap), because they have no smooth border line over their open and closed squares, and that might look strange if some touch and some dont. Fixes: #1106 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
force-pushed
the
feature/change-powerline-scaling
branch
from
6ce79ed to
ce33e9c
Compare
|
This is how narrow symbols look like (note this is an older font, it has the cell size wrong):
Font version 2.3.3 and I believe the decisions on what is wide and what not is ok:
Font version 2.3.3-69 |
|
The gaps (thin vertical lines) after the right hand side flames and waveform seen with iTerm2 is not visible in terminal:
🤔 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[why]
The Powerline extra glyph sizing is not really clear.
[how]
of possible.
For the small and big Squares add a tiny bit of border (negative
overlap), because they have no smooth border line over their open and
closed squares, and that might look strange if some touch and some dont.
Fixes: #1106
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)
Will follow