-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few Powerline Extra symbols
in Caskaydia Cove Regular
are monospaced
#1106
Comments
Powerline Extra symbols
in CascadiaCode Regular
are monospaced Powerline Extra symbols
in Caskaydia Cove Regular
are monospaced
Thanks for reporting. This needs some thoughts, but here the list of behaviours, the glyphs you mean are marked (The problem is that the powerline glyphs need to have some dependable size, so they must be scaled in any case, the question is just ... how) What is you use-case? Can you describe what you want to do? In fact I thought if we want to have |
These are the glyphs: While I see the possibility to a maximize Y while keeping pa for the lower set, the big and small squares have the problem that there are matching right-hand-side icons, which are hand to handle for the But lets see how to implement something for the lower set |
I am only using the fire symbols but encountered this small difference between Delugia Complete and Caskaydia Cove (as mentioned in adam7/delugia-code#80) I didn't went through the patching logic yet but I assume the respective symbols needs to be scaled along |
The flames are xy scaled (acpect ratio is lost, x and y independently maximized) in a 2-cell length for non-mono (and a 1 cell length of course for --mono). In this way there width is deterministic and it is more easy to use left and right aligned versions together. At least that was my reasoning. Are they ok for you? The problem with the legos is, that they are so wide, if they are scaled Y wise so big that they fill 'one height', the width will be more than 2 cells, which breaks the 'all glyphs are between 1 and 2 cells wide' promise. Its a simple change to have the lower symbols (hexagons, legos) scaled preserve-aspect-ratio into a 1 height 2 wide target. But then they will of course be also preserve-aspect-ration scaled for Here's an overview blue: x and y maximized into one cell Mono font: The legos come out smallish when we switch from 'pa' to 'xz' just for Any ideas and input welcome :-) |
Note to self: The small and big squares ... maybe they can be |
See #1106 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
I use Caskaydia Cove as my terminal font and I've also noticed weird sizing issues with the flame glyphs. I wasn't sure if this was a problem with the font or with Windows Terminal's font rendering. This sounds related though. and in the Windows font settings dialog: The wideness of the glyphs seems to confuse the font rendering. If I switch to the Complete Mono version it renders fine, but the flame glyphs are mashed into a single char width. Is this a limitation (or bug) of the font or is it a problem with how it's rendered? |
@arpsmack |
What would be the rendering you want/expect? Both In the non-Mono variant it is packed into two cells, like all other icons (for example the warning or light bulp icon in your last line, which is wider than one 'cell'): The wider symbols are the reason for the non-Mono font. With the non-Atlas rendering the non-Mono version renders ok as far as I can see - if one expects the powerline divider to be two-cells wide like the other symbols: On the right hand side of that prompt, what is missing is the blank after the divider. You immediately switch color and so the rest of the divider becomes hidden. The Atlas engine on the other hand seems to scale down the warning icon, but not the powerline dividers. They are just cut off. Whatever. |
I'm not sure which version of the font you are using, unfortunately the screenshot is but off just above. Comparison with you image, where the first flame draws over the The flames are 2 cells wide (but occupy only one, like all the other bigger glyphs), so you need a blank after the icon and all looks good: (Well, not with the font version you are using, because there the flame is even wider than 2 cells). In Windows Terminal I see the same behavior: Well, you do not want small symbols of
See also
|
@Finii It makes sense that the glyph would be a single cell in monospace, and potentially 2 in non-mono. For me personally, either would look fine as long as they're not rendered with the boundary/scaling issue I'm currently seeing. However, if I'm understanding correctly, it seems like those issues have more to do with the Terminal's rendering engines than the font itself, so it may be their problem to fix instead. |
@Finii Works great! Can't believe I didn't think to add extra space characters to pad out the extra wide flames. I apologize for adding noise to the issue. |
The cheat sheet actually uses the Well, all terminals render the fonts differently. And which Nerd Font variant works best depends on that. But there are also our 'design goals'. The different variants try to stick to that and transmogrify the gyphs to best implement the design goal. For the powerline symbols we have really different rules for each glyph. We can change them that it represents best what people expect. How it comes out is then further different for the different variants, but the rules set the stage. And here we can play and change the general rules for each powerline glyph individually. For example # Arrow tips
0xe0b0: {'align': 'l', 'valign': 'c', 'stretch': 'xy', 'params': {'overlap': 0.02, 'xy-ratio': 0.7}},
0xe0b1: {'align': 'l', 'valign': 'c', 'stretch': 'xy', 'params': {'xy-ratio': 0.7}}, You see that we want both to be
These abstract rules are taken by the font-patcher and depending on variant result in different glyph-implementations. Whatever... We can decide ... shall the flames be always one cell or allowed to be two cell if possible. And here is the place to speak up. What would you expect, what do you want, etc. I personally do not use all these fancy icons and so I have no clue what people want ;-) I can just solve the problems technically. So. There are always rendering problems for wider-than-one-cell glyphs. Nonetheless most people want not-tiny icons and use these font variants. That seems all straight forward. But when it comes to the actual powerline glyphs, this is more complicated because most of them shall also reach up to the whole line spacing. And that is where the problems come. See the differently colored groups in #1106 (comment). This is just what I dreamed up one night. We can change the groups and or their members. |
@arpsmack Thanks for the feedback! And if I read you correctly you would be not happy with flames that are only one cell wide, right? Edit: What for a typo 🤣 Gollum: "my preciousssss" |
I've always wanted the wider flames just like how they look on the nerd fonts home page. I think the mono ones look bad. I couldn't figure out what I was doing wrong... until now! |
My verdict would be
|
To be frank, lego and hexagons are probably the least used powerline symbols. So they aren't used in place of Arrow tips or Rounded arcs.
v2.3.0-RC font patcher Lines 662 to 714 in da88bdb
The way these glyphs were designed: See how flames/waveform/squares/lego/hexagons are 2 cell wide (end to end of the square boundary) |
[why] The Powerline extra glyph sizing is not really clear. [how] Make the triangulars 1 cell wide, as for example Iosevka also does. Make the Legos 2 cell wide with pa scaling to make them look nicer. Make the Hexagons 2 cells wide and keep their aspect ratio if possible. Make small and big Squares also 2 cell wide and keep their aspect ratio of possible. For the small and big Squares add a tiny bit of border (negative overlap), because they have no smooth border line over their open and closed squares, and that might look strange if some touch and some dont. Fixes: #1106 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
This will 1123 do:
For the small and big Squares add a tiny bit of border (negative Opinions? (Maybe post opinions in the PR thread) |
[why] The Powerline extra glyph sizing is not really clear. [how] Make the triangulars 1 cell wide, as for example Iosevka also does. Make the Legos 2 cell wide with pa scaling to make them look nicer. Make the Hexagons 2 cells wide and keep their aspect ratio if possible. Make small and big Squares also 2 cell wide and keep their aspect ratio of possible. For the small and big Squares add a tiny bit of border (negative overlap), because they have no smooth border line over their open and closed squares, and that might look strange if some touch and some dont. Fixes: #1106 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] The Powerline extra glyph sizing is not really clear. [how] Make the triangulars 1 cell wide, as for example Iosevka also does. Make the Legos 2 cell wide with pa scaling to make them look nicer. Make the Hexagons 2 cells wide and keep their aspect ratio if possible. Make small and big Squares also 2 cell wide and keep their aspect ratio of possible. For the small and big Squares add a tiny bit of border (negative overlap), because they have no smooth border line over their open and closed squares, and that might look strange if some touch and some dont. Fixes: #1106 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] The Powerline extra glyph sizing is not really clear. [how] Make the triangulars 1 cell wide, as for example Iosevka also does. Make the Legos 2 cell wide with pa scaling to make them look nicer. Make the Hexagons 2 cells wide and keep their aspect ratio if possible. Make small and big Squares also 2 cell wide and keep their aspect ratio of possible. For the small and big Squares add a tiny bit of border (negative overlap), because they have no smooth border line over their open and closed squares, and that might look strange if some touch and some dont. Fixes: ryanoasis#1106 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
[why] The Powerline extra glyph sizing is not really clear. [how] Make the triangulars 1 cell wide, as for example Iosevka also does. Make the Legos 2 cell wide with pa scaling to make them look nicer. Make the Hexagons 2 cells wide and keep their aspect ratio if possible. Make small and big Squares also 2 cell wide and keep their aspect ratio of possible. For the small and big Squares add a tiny bit of border (negative overlap), because they have no smooth border line over their open and closed squares, and that might look strange if some touch and some dont. Fixes: ryanoasis#1106 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Requirements
🎯 Subject of the issue
Experienced behavior:
Few
Powerline Extra symbols
inCaskaydia Cove Regular
are monospaced.v2.3.0
and above releases.Expected behavior:
CascadiaCode Regular
orCaskaydia Cove Nerd Font Complete Regular
is non-monospaced font. So the above mentioned symbols should be wider.v2.3.0-RC
and below releases.Example symbols:
E0C4
: E0C5
: E0C6
: E0C7
: E0CC
: E0CD
: E0CE
: E0CF
: E0D1
: 🔧 Your Setup
Anonymice Powerline Nerd Font Complete.ttf
)?iterm2
,urxvt
,gnome
,konsole
)?★ Screenshots (Optional)
Included above
The text was updated successfully, but these errors were encountered: