Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setSubText in android notification area. #515

Open
wants to merge 1 commit into
base: minor
Choose a base branch
from
Open

setSubText in android notification area. #515

wants to merge 1 commit into from

Conversation

subhash279
Copy link
Contributor

In the original code, even though there was an option to setSubText in android notification area, the getDescription() method always returned null. This is because the description was not set anywhere earlier in code and from what I checked, there was no easy way to do it. So I used displayDescription to set subtext in notification area.
Pls correct me if my understanding of anything is wrong.

@subhash279
Copy link
Contributor Author

@ryanheise pls let me know if you need any other changes to merge this PR.

@ryanheise
Copy link
Owner

Hi @subhash279 all focus is now on the one-isolate branch, and I am trying to get that release out. I do not plan on making another release on the old version, so if you would be interested to see this change incorporated, you might like to submit the PR for the one-isolate branch.

@subhash279
Copy link
Contributor Author

@ryanheise got it thanks. I will make the PR on the other branch soon.

@ryanheise ryanheise changed the base branch from master to minor October 17, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants