Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript support #10

Open
3 tasks
rwieruch opened this issue Oct 19, 2019 · 5 comments
Open
3 tasks

Add TypeScript support #10

rwieruch opened this issue Oct 19, 2019 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rwieruch
Copy link
Owner

rwieruch commented Oct 19, 2019

Is it possible to add TS support?

  • remove prop-types from code and package.json
  • add minimalistic typescript support
  • add type safety for title prop in src/App.js component
@rwieruch rwieruch added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 19, 2019
@simply-alliv
Copy link

I read your blog posts and thank you for all the tips and tricks you've been writing. Anyway, I think I can tackle this issue. Are you planning to just add type declarations or go all TypeScript by also converting the files to .ts and .tsx files?

@rwieruch
Copy link
Owner Author

Converting the files would be great too. Would be awesome to see a PR coming from you!

@simply-alliv
Copy link

Cool beans! I had already jumped the gun earlier so I have a pull request with the required changes. I just need you to review it.

@rwieruch
Copy link
Owner Author

How is it going with the PR @AlliVil :)

@simply-alliv
Copy link

If I'm not mistaken, I've already made a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants