Implement optional support for axum 0.8's Listener trait #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything about this PR is mostly obvious, with the feature being named
axum08
similarly to thetonic
-related compat features. There is one exception, however, that being the accept error handling behavior: theListener
'saccept
definition is infallible and states:I used the approach
axum
developers themselves used for implementingListener
for TCP and UDS listeners, more info in thehandle_accept_error
method that is almost a direct copy-paste fromaxum
's internals. My assumption is that if it's considered "good enough" byaxum
, it should be fortokio-vsock
, but I might be wrong.