Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Ownership Part 2 content into Part 1 #51

Closed
jespiron opened this issue Jan 16, 2025 · 2 comments
Closed

Move Ownership Part 2 content into Part 1 #51

jespiron opened this issue Jan 16, 2025 · 2 comments

Comments

@jespiron
Copy link
Member

In #50

Any chance we can move this lecture 5 content to lecture 2?
image

The parts I like are

Even a subset of the above suggestions is good! I recognize this makes the first half of lecture 5 redundant, in which I'm willing to rewrite lecture 5.

I think these changes are worth the effort, since it makes Lecture 2 intuitive while giving us more avenue for lecture 5 content.

@connortsui20
Copy link
Member

I don't know how much time you have, but if you could make a PR to lecture 2 showing high level changes (you don't have to write out entire slides, just add titles and a brief description of what the slide shows) I think it would make making a decision easier.

Lecture 2 is already packed with information, and is also one of the lecture that tends to go over. The goal of having the new Ownership (Part 2) lecture was to take information out of lecture 2 and move it somewhere else, so I am super hesitant to move more stuff into lecture 2.

I'm sure adding this stuff is a good idea, but we also need to make sure students can do the homework. I don't know exactly which of these variables need to change, so if you have time to make a draft PR to lecture 2 that would be great.

@jespiron
Copy link
Member Author

The timing is indeed difficult.

After playing around with this, I decided Part 1 is sufficiently explained.

I opted for a smaller change, of rearranging and trimming: #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants