Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let clap handle all CLI parsing errors #2656

Merged
merged 10 commits into from
Oct 3, 2023

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Oct 3, 2023

This PR removes some ad-hoc error propagation that the CLI parser had for more sophisticated arguments and just uses clap::Error for everything.

@pvdrz pvdrz merged commit 7b95673 into rust-lang:main Oct 3, 2023
27 checks passed
@pvdrz pvdrz deleted the pvdrz-better-errors branch October 3, 2023 21:06
@Gelbpunkt
Copy link

@pvdrz hi there, I think that these changes broke bindgen --version since a header path is now required. I can file a separate issue for this if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants