-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check token validity when loading registry config #15127
base: master
Are you sure you want to change the base?
Conversation
a3aedb6
to
441fd35
Compare
if let Some(RegistryConfig { | ||
token: Some(token), .. | ||
}) = &cfg | ||
{ | ||
check_token(&token.val.as_deref().expose()).with_context(|| { | ||
format!( | ||
"Token for {sid} is invalid (defined in {})", | ||
token.definition | ||
) | ||
})?; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is moving the check from
- token credential provider
To
- token credential provider
- paseto credential provider
- the enumeration of all credential providers
I'd want to better understand if its a good idea to be running this check in all of those other situations
CC @arlosi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Construction of RegistryConfig
is closer to TOML deserialization of credentials.toml
than to implementation of credential providers. The token here is the input for downstream users of the registry config, and does not touch output token of credential providers (that's CredentialResponse
).
Paseto uses secret_key
and secret_key_subject
fields, not token
.
This field is only read by TokenCredential
, apart from code that warns when cargo::token
is not enabled.
This change checks validity of registry tokens earlier, when they're read from the config. Previously Cargo would check the token only when sending a request.
This makes the error message more helpful, because it can tell how the token has been defined. This is especially helpful when users do something like: