sdmmc: add HAL traits for SD/MMC peripherals #662
Conversation
Adds the initial implementation of the `embedded-hal` SD/MMC traits. Includes types and traits useful for handling SD/MMC peripherals.
There was a problem hiding this comment.
Thank you! I started reviewing, but I think this PR needs a bit more work.
Did you get a chance to read https://github.com/rust-embedded/embedded-hal/blob/master/docs/how-to-add-a-new-trait.md?
This PR is missing some background work, and demonstration that it can be implemented on at least two targets.
Finally, is this worth abstracting over in eh? This feels like it could be a really great addition to the ecosystem, but equally how sure are we that we're going to cover every controller operation (and the fact you're trying to cover SPI commands here too) with these abstractions?
Perhaps a more worthwhile abstraction for eh would be a block device trait?
This PR might be better as a stand alone crate, at least initially, to demonstrate its viability.
| type Error; | ||
|
|
||
| /// Gets whether the device is a MMC card. | ||
| fn is_mmc(&self) -> bool; |
There was a problem hiding this comment.
Imo all these bools should be enums, like CardType::Sd and TransportMode::Spi
Adds the initial implementation of the
embedded-halSD/MMC traits.Includes types and traits useful for handling SD/MMC peripherals.