fix expect![[]] #38
Open
fix expect![[]] #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxchan
commented
May 18, 2023
src/lib.rs
Outdated
| @@ -850,7 +855,7 @@ line1 | |||
| ); | |||
|
|
|||
| // Check `expect![[ ]]` as well. | |||
| assert_eq!(locate_end("]]"), Some(0)); | |||
| assert_eq!(locate_end("[]]"), Some(2)); | |||
There was a problem hiding this comment.
The tests should have [ at the beginning.
There was a problem hiding this comment.
- Is the original test still relevant?
- If so, should we leave in both assertions?
- If so, what should it equal?
Suggested change
| assert_eq!(locate_end("[]]"), Some(2)); | |
| assert_eq!(locate_end("]]"), todo!()); | |
| assert_eq!(locate_end("[]]"), Some(2)); |
There was a problem hiding this comment.
Wait, I think actually it's not relevant. Because locate is used for update. But when update is called, the syntax has to be correct.
|
It seems to break in #27. ping @ecstatic-morse @matklad to take a look |
|
@xxchan Is the PR ready to be merged? I'm taking a look now… |
Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
force-pushed
the
xxchan/nursing-bovid
branch
from
207bbe3 to
5d4cb8e
Compare
Signed-off-by: xxchan <xxchan22f@gmail.com>
|
I just came up with a better solution |
xxchan
force-pushed
the
xxchan/nursing-bovid
branch
from
75e4580 to
7178666
Compare
|
is this project abandoned? I just came here inquiring about the same issue and I see it's not been merged after months... |
|
Still maintained. When I last checked, the PR wasn’t ready to merge. I’ll take another look later today!
…On Thu, Oct 24, 2024, at 04:57, Simon Thornington wrote:
is this project abandoned? I just came here inquiring about the same issue and I see it's not been merged after months...
—
Reply to this email directly, view it on GitHub <#38 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF3WNMUTQXI5B3VH7QTNLZ47PP3AVCNFSM6AAAAAAYGRANFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZTGAYTOMBSGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
kindly ping @quad |
xxchan
added a commit
to xxchan/expect-test
that referenced
this pull request
Dec 19, 2024
Currently recommended `expect![[]]` is broken rust-analyzer#37, and rust-analyzer#38 is blocked for long time, so maybe we can update the recommendation to a safer option instead. Signed-off-by: xxchan <xxchan22f@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #37