-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Parametrize number of files in diff from azure devops endpoint #5298
base: main
Are you sure you want to change the base?
Conversation
@bub3n Thanks for the PR. Could you write some tests for this? Thanks. |
@jamengual sure, I'll prepare something |
@jamengual Tried to add test for new client with top and skip arguments. Idea behind this is to test client without and with the behavior so we know if it won't break the default setup |
Hi @bub3n, I started to have a look at this PR, but it looks like you have got a lot of unrelated changes committed. Can you review these and remove anything unrelated to the description in the PR. Thanks. |
Yeah, my bad. Working on a fix. Sorry for troubles |
Signed-off-by: Petr Bubenik <petr.bubenik@drmax.eu>
Signed-off-by: Petr Bubenik <petr.bubenik@drmax.eu>
No problem. I assume this fixes the pagination of the relevant Azure DevOps API call, but I don't think we need additional server parameters to adjust the pagination. We are trying to avoid adding server parameters that aren't necessary. |
… files I want from PR Signed-off-by: Petr Bubenik <petr.bubenik@drmax.eu>
Cherry pick my changes
@X-Guardian unfortunately it does not. I guess you are right, my bad. I'll rework it for pagination. BTW what number of elements would you say is good per "page"? 100 which is their API default? |
Yes, I'm sure the default will be fine. |
what
why
tests
make test
without any errorsreferences