Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add llm integration with Intel Gaudi in llama-index-llms-gaudi #16308

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jeanyu-habana
Copy link

Description

This PR adds Intel Gaudi support to the list of llama_index llm integration. This enables users to run llm locally on Intel Gaudi using llama_index modules.

Fixes # (issue)
N/A

New Package?

None
Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 30, 2024
@logan-markewich
Copy link
Collaborator

@jeanyu-habana can you run make lint ? Many linting issues

@logan-markewich logan-markewich self-assigned this Oct 1, 2024
@jeanyu-habana
Copy link
Author

@jeanyu-habana can you run make lint ? Many linting issues

Ran "make lint" and fixed errors.

@jeanyu-habana
Copy link
Author

@jeanyu-habana can you run make lint ? Many linting issues

Ran "make lint" and fixed errors.

Done.

@jeanyu-habana
Copy link
Author

@logan-markewich Would you be able take another look at the changes made and let me know if previous comments can be resolved? I'd appreciate it.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 8, 2024
@logan-markewich
Copy link
Collaborator

We added some checks for unit tests 😅 Would it be possible to add some?

Could be similar to what I did here
#16413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants