Add Falkordb vectorstore Integration #16047
Open
+671
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AviAvni
suggested changes
Sep 19, 2024
|
|
||
| _logger = logging.getLogger(__name__) | ||
|
|
||
| def check_if_not_null(props: List[str], values: List[Any]) -> None: |
There was a problem hiding this comment.
this function only used once just inline it
|
|
||
| def retrieve_existing_index(self) -> bool: | ||
| index_information = self._driver.query( | ||
| "SHOW INDEXES " |
There was a problem hiding this comment.
replace with
CALL db.indexes()
| def retrieve_existing_index(self) -> bool: | ||
| index_information = self._driver.query( | ||
| "SHOW INDEXES " | ||
| "YIELD name, type, entityType, properties, options " |
There was a problem hiding this comment.
see output in https://docs.falkordb.com/cypher/procedures.html
| filter_params = {} | ||
|
|
||
| similarity_query = ( | ||
| f"WITH n, vector.similarity.{self.distance_strategy}(" |
There was a problem hiding this comment.
see https://docs.falkordb.com/cypher/indexing.html#vector-indexing how to use vector indexing
AviAvni
reviewed
Sep 24, 2024
|
@AviAvni please have a look at docs and if there's anything you think we need to change drop a comment, I'll fix it asap. |
AviAvni
suggested changes
Sep 24, 2024
| from llama_index.vector_stores.falkordb import FalkorDBVectorStore | ||
|
|
||
| vector_store = FalkorDBVectorStore( | ||
| url="bolt://localhost:7687", |
AviAvni
approved these changes
Sep 25, 2024
dosubot
bot
added
the
size:XL
|
@logan-markewich can you please review/merge? |
logan-markewich
approved these changes
Sep 30, 2024
|
yes, they were working fine for me, but if you need any help regarding anything, tag me and I will try my best to help you.
…On Sat, Oct 5, 2024 at 12:25 AM Logan ***@***.***> wrote:
@gkorland <https://github.com/gkorland> @AviAvni
<https://github.com/AviAvni> I fixed a handful of issues, but the unit
tests don't seem to work. Did you run them locally?
—
Reply to this email directly, view it on GitHub
<#16047 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5MFIX7JLYITNO3DTJLIXGTZZ3TTDAVCNFSM6AAAAABOJYEEZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUGQZTGOBYG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@A5jadAli try running them, they don't actually work. Previously the mock db client wasn't being used (and the URL was also invalid) -- changed it slightly to use the mock client so that things are actually testable in CICD, but most tests fail (likely because things aren't mocked out entirely) |
|
Ok, I'll check it out.
…On Sat, Oct 5, 2024 at 9:54 PM Logan ***@***.***> wrote:
@A5jadAli <https://github.com/A5jadAli> try running them, they don't
actually work. Previously the mock db client wasn't being used (and the URL
was also invalid) -- changed it slightly to use the mock client so that
things are actually testable in CICD, but most tests fail (likely because
things aren't mocked out entirely)
—
Reply to this email directly, view it on GitHub
<#16047 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5MFIX2MHGZ5ZPU4J754DTDZ2AKVFAVCNFSM6AAAAABOJYEEZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGEYTMMZXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for FalkorDB as a vectorstore option in LlamaIndex. The changes include: