Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bzlmod version requires protoc 4.X and above #389

Open
jduan opened this issue Dec 10, 2024 · 0 comments
Open

bzlmod version requires protoc 4.X and above #389

jduan opened this issue Dec 10, 2024 · 0 comments

Comments

@jduan
Copy link

jduan commented Dec 10, 2024

Description

Hi,

I believe rules_proto_grpc uses toolchains_protoc to generate code that corresponds to proto version 4.X and above.

While proto 4.X has been out since Q1 2024 (see https://protobuf.dev/support/version-support/#java), many open source libraries haven't adopted 4.X yet. For example, even some Google libraries are still only working with proto 3.X.

For example, com.google.cloud:google-cloud-dlp still only works with proto-buf 3.X. I believe many other libraries from "com.google.cloud" are the same.

Is it possible to publish a version of "rules_proto_grpc" that works with protobuf 3.X? It's probably a big ask. But it's a practical ask 😄

PS: I'm trying to adopt bzlmod and our large code base is still mostly working with proto 3.X at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant