Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible official support for pyi files generated in rules_proto_grpc_python? #369

Open
planeyang opened this issue Oct 20, 2024 · 1 comment
Labels
resolved-next-release Code to resolve issue is pending release

Comments

@planeyang
Copy link

Description

Hi,

I wonder if the maintainer of this project would kindly consider support pyi files generation for rules_proto_grpc_python.

Here are some prior arts:

Is there anything we can help from the user side to push this forward?

Thank you

@harrisonfang-helm
Copy link

Shout out to this nice blog post that references this issue. If anyone is trying to use pyi generation ahead of the next official release, this snippet will handle the fact that the repo has multiple modules and a dependency between them.

bazel_dep(name = "rules_proto_grpc", version = "5.0.1")

git_override(
    module_name = "rules_proto_grpc",
    remote = "https://github.com/rules-proto-grpc/rules_proto_grpc.git",
    commit = "d17b5b16c8b12143c6f1b78dabd6bbc228e89b58",
    strip_prefix = "modules/core",
)

bazel_dep(name = "rules_proto_grpc_python", version = "5.0.1")

git_override(
    module_name = "rules_proto_grpc_python",
    remote = "https://github.com/rules-proto-grpc/rules_proto_grpc.git",
    commit = "d17b5b16c8b12143c6f1b78dabd6bbc228e89b58",
    strip_prefix = "modules/python",
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolved-next-release Code to resolve issue is pending release
Projects
None yet
Development

No branches or pull requests

3 participants