Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy package support for Rucio server #223

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Conversation

rdimaio
Copy link
Contributor

@rdimaio rdimaio commented Feb 4, 2025

Initial PR to add policy package support to the Rucio server.

Current questions:

  • Does the |'d command work when using multiple packages? (edit: it does)

@rdimaio
Copy link
Contributor Author

rdimaio commented Feb 5, 2025

Amended version works correctly. Used these values:

policyPackages:
  enabled: true
  # Make sure the trailing slash is present
  mountPath: /opt/policy_packages/
  # Use underscores instead of hyphens for package names
  # (e.g. atlas_rucio_policy_package instead of atlas-rucio-policy-package)
  packages:
    - moduleName: atlas_rucio_policy_package
      requirement: atlas-rucio-policy-package==0.4.0
      version: 0.4.0
    - moduleName: belleii_rucio_policy_package
      requirement: git+https://github.com/rucio/temporary-belle2-policy-package@v0.1.0
      version: 0.1.0
  resources:
    requests:
      storage: 100Mi

First deployment installs both policy packages as expected, second deployment does not install anything as they already installed.

@rdimaio rdimaio force-pushed the 221-policy branch 3 times, most recently from 31625d0 to 360a0c7 Compare February 10, 2025 09:56
@rdimaio rdimaio linked an issue Feb 13, 2025 that may be closed by this pull request
@rdimaio rdimaio force-pushed the 221-policy branch 2 times, most recently from 9faa675 to 63c6a6a Compare February 21, 2025 18:15
@rdimaio rdimaio requested a review from dchristidis February 21, 2025 18:15
@rdimaio rdimaio marked this pull request as ready for review February 21, 2025 18:15
@rdimaio rdimaio changed the title Draft PR: policy package support for Rucio server Policy package support for Rucio server Feb 21, 2025
Copy link
Contributor

@dchristidis dchristidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I took the liberty of making a few additional style-related comments that are undoubtedly a matter of personal opinion. They apply in general and not exclusively to the lines and/or file they refer to. Feel free to ignore them.

@rdimaio rdimaio merged commit 8219a31 into rucio:master Feb 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policy package deployment: using an init container
2 participants