-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default upload text should change to file name #121
Comments
Can I work on this issue? |
@chandan270 that would be great. Just wait for @garettarrowood's ping, and you can work on the issue. |
Thanks @chandan270 ! |
@chandan270 - Are you still interested in completing this work? Just checking in. |
@garettarrowood I'll fix this issue this after the 8th of this month. |
That'd we great! Thanks @Ashvith ! |
@garettarrowood need some help with adding Javascript. I am actually clueless about where we can add JS files here. Is it supposed to be inside This is what I wanted to add:
|
@Ashvith - I'm not experienced with I would say try it in a couple places that seem to make sense, and use your best judgement. As long as we get it working, and its named well (as in, the file is named well), we should be able to either run with your convention, or refactor it to another place as we grow smarter/more experienced :) . |
@garettarrowood Looks like this is out of my experience too. If you want to, I could have a look at some of the tutorials, and examples and maybe fix this sometimes later? |
If you can even get this to work in a |
I've tried the |
Can I take over and work on this issue? @garettarrowood |
Summary
PR #120 solves the styling of the modal, but the "No file selected message" does not change to the name of the file uploaded.
Things to Consider
span
tag which encloses the default message.This page would be a nice material to refer to.
Criteria for Completion
No file selected
should be replaced with the file name.What it looks like right now:
What it should look like:
The text was updated successfully, but these errors were encountered: