Rename test classes from Test* to *Test #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rdoc with
|
| Latest commit: |
50b216f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://22278d14.rdoc-6cd.pages.dev |
| Branch Preview URL: | https://rename-test-classes.rdoc-6cd.pages.dev |
|
It will make sense to rename files as well IMHO to keep it consistent. |
Since class names are usually nouns, test classes should be named like `ClassNameTest` instead of `TestClassName`. This convention is now commonly used in projects (e.g. Rails) and tools like Ruby LSP use it to check if a class is a test class. (From tools' perspective, checking `Test` as a postfix is more accurate than checking `Test` as a prefix as `TestHelper`, `TestCase`...etc. are not test classes.) I've previously renamed some classes this way. This commit renames all remaining classes to follow the convention.
st0012
force-pushed
the
rename-test-classes
branch
from
ab18204 to
50b216f
Compare
|
I've renamed the test files too. It'd require almost all opened PRs to rebase, but it should be rather easy to do. |
|
Windows head CI are failing for unrelated reasons. Merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since class names are usually nouns, test classes should be named like
ClassNameTestinstead ofTestClassName.This convention is now commonly used in projects (e.g. Rails) and tools like Ruby LSP use it to check if a class is a test class. (From tools' perspective, checking
Testas a postfix is more accurate than checkingTestas a prefix asTestHelper,TestCase...etc. are not test classes.)I've previously renamed some classes this way. This commit renames all remaining classes to follow the convention.