Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.4 to spec matrix #13626

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented Dec 26, 2024

Now that Ruby 3.4 is out, head will relate to the 3.5 development branch, so 3.4 needs to be explicitly given.

PR for setup-ruby is here: ruby/setup-ruby#677. Even though it's not yet merged (although I assume it will be shortly), an explicit "3.4" will still work (but refer to the release candidate for now).

head already is 3.5, as seen here: https://github.com/rubocop/rubocop/actions/runs/12496246734/job/34867800491?pr=13624#step:3:18 (can be seen in the GH actions of this PR as well)

@bbatsov bbatsov merged commit 020c1bf into rubocop:master Dec 26, 2024
23 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Dec 26, 2024

Merry Christmas! 🎄

@dvandersluis dvandersluis deleted the github-actions-3.4 branch December 26, 2024 07:04
@dvandersluis
Copy link
Member Author

You too @bbatsov!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants