Fewer inline disabled cops #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darhazer
approved these changes
Feb 11, 2025
This includes fixing a `Naming/PredicateName` offense, and one `Style/GuardClause` offense. Not sure why Lint/RedundantCopDisableDirective didn't find these.
The default is 10, which seems to be just a bit too low for our code.
bquorning
force-pushed
the
fewer-inline-disabled-cops
branch
from
21bf860 to
2edbf15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit removes a few unnecessary RuboCop disables. This includes fixing a
Naming/PredicateNameoffense, and oneStyle/GuardClauseoffense.I am not sure why
Lint/RedundantCopDisableDirectivedidn't find the unnecessary disabling ofRSpec/ExampleLength🤷🏼The second commit loosens
Metrics/MethodLengthMax to 15. The default is 10, which seems to be just a bit too low for our code.Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).