-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md
to include Simplecov
#2035
Merged
bquorning
merged 1 commit into
rubocop:master
from
corsonknowles:add_simplecov_to_contribution_guidelines
Feb 9, 2025
Merged
Update CONTRIBUTING.md
to include Simplecov
#2035
bquorning
merged 1 commit into
rubocop:master
from
corsonknowles:add_simplecov_to_contribution_guidelines
Feb 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bquorning How does this look? Amendments and improvements welcome. |
bquorning
reviewed
Feb 9, 2025
86edd21
to
48bb0f6
Compare
bquorning
approved these changes
Feb 9, 2025
bquorning
reviewed
Feb 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have mdformat available locally? mdformat .
should fix the CI.
I can do that!
It will be a few hours until I am back online today.
|
2dd381a
to
8429c46
Compare
Formatted! |
Yeah, but… Maybe we should merge #2037 first? |
8429c46
to
a7da808
Compare
Good call! This latest amendment should get it passing enough to merge in either order. |
bquorning
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Simplecov instructions, common usage, and the repo link to our
CONTRIBUTING.md
guidelines.Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml
.Enabled: pending
inconfig/default.yml
.Enabled: true
in.rubocop.yml
.VersionAdded: "<<next>>"
indefault/config.yml
.If you have modified an existing cop's configuration options:
VersionChanged: "<<next>>"
inconfig/default.yml
.