Add eql/equal support to RSpec/PredicateMatcher #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
force-pushed
the
predicate-matcher-eql-equal
branch
from
ab5f824 to
ec1e83b
Compare
corsonknowles
approved these changes
Feb 9, 2025
pirj
approved these changes
Feb 10, 2025
| @@ -106,7 +106,7 @@ def rewrite_matcher(corrector, predicate, matcher) | |||
|
|
|||
| def true?(to_symbol, matcher) | |||
| result = case matcher.method_name | |||
| when :be, :eq | |||
| when :be, :eq, :eql, :equal | |||
There was a problem hiding this comment.
A few aliases to make this complete? https://github.com/rspec/rspec/blob/a80119c703d38f993c414490abe8c992154cf5d1/rspec-expectations/lib/rspec/matchers.rb#L578
I just went there just in case, I don't think I've seen those used once in my practice 🙈 So really up to you.
There was a problem hiding this comment.
Yeah, I have never seen those used either. I think there’s no need to add them now.
The `be_bool?` node matcher was already finding nodes using `eql` and `equal`, but then didn't properly handle them.
bquorning
force-pushed
the
predicate-matcher-eql-equal
branch
from
ec1e83b to
49b9b21
Compare
ydah
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
be_bool?node matcher was already finding nodes usingeqlandequal, but then didn't properly handle them.Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).