Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .simplecov #1971

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Conversation

corsonknowles
Copy link
Contributor

@corsonknowles corsonknowles commented Oct 13, 2024

Require full line coverage

Depends on both:


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

  • Added the new cop to config/default.yml.
  • The cop is configured as Enabled: pending in config/default.yml.
  • The cop is configured as Enabled: true in .rubocop.yml.
  • The cop documents examples of good and bad code.
  • The tests assert both that bad code is reported and that good code is not reported.
  • Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

  • Set VersionChanged: "<<next>>" in config/default.yml.

@bquorning bquorning force-pushed the require_full_line_coverage branch from f53edc1 to 94a509d Compare October 26, 2024 08:55
@bquorning bquorning merged commit f5d9784 into rubocop:master Oct 26, 2024
24 checks passed
@bquorning
Copy link
Collaborator

Thank you @corsonknowles ❤️ Even in the last couple of weeks we have seen a few issues where 100% test coverage would have helped prevent problems.

@pirj
Copy link
Member

pirj commented Oct 26, 2024

This is big, @corsonknowles ! Thanks a lot!

@corsonknowles
Copy link
Contributor Author

Thanks team! Great working with you on this!

@bquorning bquorning added this to the Code coverage milestone Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants