Extract RSpec Rails cops

[ydah]

Fix: #1734

TODO

• once the gem is published, adds rubocop-rspec_rails to gemspec and remove from Gemfile
• set the version constraint in gemspec for rspec-rspec_rails
• Creating a Repository for https://github.com/rubocop/rubocop-rspec_rails
• Extracted to https://github.com/rubocop/rubocop-rspec_rails

Here's where to temporary extract it:.

• Extract RSpec Rails cops ydah/rubocop-rspec_rails#1

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Updated documentation.
• Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[ydah]

@rubocop/rubocop-rspec We can now proceed to extraction 🎉
@bquorning Could you create https://github.com/rubocop/rubocop-rspec_rails?

[pirj]

Should we do rubocop-rspec_rails with underscore lije we do for rubocop-factory_bot?
As a repo name and in the code especially: we’ll use RuboCop::RSpecRails as the namespace, right?

[ydah]

Should we do rubocop-rspec_rails with underscore lije we do for rubocop-factory_bot? As a repo name and in the code especially: we’ll use RuboCop::RSpecRails as the namespace, right?

I was wondering whether it should be separated by hyphen or underscore. In factory_bot, the name of the original gem is separated by underscore, but rspec-rails is separated by hyphen.
Does the name rspec_rails sound strange? If it doesn't sound strange, I will change the name of the repository.
@rubocop/rubocop-rspec I'd like to hear your opinion.

[bquorning]

Based on https://guides.rubygems.org/name-your-gem/ and e.g. https://github.com/ydah/rubocop-rspec-rails/blob/207fc3483e75605b12276b90e5bb3a7ebcdc223f/lib/rubocop/cop/rspec_rails/avoid_setup_hook.rb defining RuboCop::Cop::RSpecRails and not RuboCop::Cop::RSpec::Rails, I think the gem should be named rubocop-rspec_rails.

[ydah]

Thank you. we use rubocop-rspec_rails instead of rubocop-rspec-rails.

[ydah]

I updated this and extracted PR.

[bquorning]

I created https://github.com/rubocop/rubocop-rspec_rails with @rubocop/rubocop-core given write-access. Ping me if anyone needs admin access.

[ydah]

@rubocop/rubocop-rspec If the modifications on the rubocop-rspec_rais side are correct, I will apply them to the https://github.com/rubocop/rubocop-rspec_rails . Please review ydah/rubocop-rspec_rails#1 .

[pirj]

I apologise for the delay. I don’t have sufficient spare time to review this fully. I hope to do this early next week. Thank you so much for the effort you’re putting into this!

[pirj]

Looks great, thank you!
Were there any modules that are needed to to run the newly-extracted extension without rubocop-rspec? Can we remove them from rubocop-rspec? I recall we had that for capybara/factory_bot.

[pirj]

I can’t spot any rails-specific modules in our code at a glance, so all good.

[pirj]

Lgtm! 😍

[ydah]

I overlooked something serious. Gems cannot depend on each other.

❯ bundle install
Your bundle requires gems that depend on each other, creating an infinite loop. Please remove either gem 'rubocop-rspec' or gem 'rubocop-rspec_rails' and try again.

[pirj]

I guess we’ll have to remove the dependency from rubocop-rspec_rails and make a note there that it implicitly depends on rubocop-rspec.
In 3.0, we’ll remove the dependency on rubocop-rspec_rails from rubocop-rspec, and will restore the dependency declaration in rubocop-rspec_rails.
This might be a mild surprise to those who would want just rubocop-rspec_rails, but I suppose it’s a very rare case.

[ydah]

@pirj Should rubocop-rspec_rails be a patch upgrade or a minor upgrade?

[pirj]

I’d yank the 2.28.0 and released a bugfix patch in 2.28.1.
@bquorning what do you think?

[bquorning]

I’d yank the 2.28.0 and released a bugfix patch in 2.28.1.

Yes that sounds like a good idea. And I assume nobody is using the gem yet, so the yank won’t affect users.

[ydah]

I update this PR. And All Green ✅

[pirj]

Awesome, thank you!

This sets a major milestone, and, to me, was he last thing stopping us from releasing 3.0 of all gems and untangling them. And enabling all cops previously marked as pending.