Add new Rails/MultipleRoutePaths cop
#1407
Open
+192
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_new_rails_multiple_route_paths_cop
branch
7 times, most recently
from
5e178f2 to
8cb2bdd
Compare
eugeneius
reviewed
Jan 8, 2025
| module RuboCop | ||
| module Cop | ||
| module Rails | ||
| # Checks if mapping a route with multiple paths is deprecated and will be removed in Rails 8.1. |
There was a problem hiding this comment.
Suggested change
| # Checks if mapping a route with multiple paths is deprecated and will be removed in Rails 8.1. | |
| # Checks for mapping a route with multiple paths, which is deprecated and will be removed in Rails 8.1. |
koic
force-pushed
the
add_new_rails_multiple_route_paths_cop
branch
from
8cb2bdd to
1c4df27
Compare
This PR adds new `Rails/MultipleRoutePaths` cop that checks for mapping a route with multiple paths, which is deprecated and will be removed in Rails 8.1. ```ruby # bad get '/users', '/other_path', to: 'users#index' # good get '/users', to: 'users#index' get '/other_path', to: 'users#index' ``` This provides a migration path for the following warning added in rails/rails#52409. ```consle DEPRECATION WARNING: Mapping a route with multiple paths is deprecated and will be removed in Rails 8.1. Please use multiple method calls instead. ... ```
koic
force-pushed
the
add_new_rails_multiple_route_paths_cop
branch
from
1c4df27 to
f305297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new
Rails/MultipleRoutePathscop that checks for mapping a route with multiple paths, which is deprecated and will be removed in Rails 8.1.This provides a migration path for the following warning added in rails/rails#52409.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.