Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InternalAffairs/CopEnabled offenses #1394

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis marked this pull request as draft December 13, 2024 17:10
@koic
Copy link
Member

koic commented Dec 13, 2024

Thank you for opening the PR. In the future, the offense of InternalAffairs/CopEnabled can be autocorrected, but considering the user impact, raising the minimum required RuboCop version just for that should not be done.

Until then, InternalAffairs/CopEnabled will be disabled:
0bbd218

Also, adjustments to the CI and gemspec are required to pass the build:
https://github.com/rubocop/rubocop-rails/actions/runs/12319520981/job/34386760752?pr=1394

@dvandersluis
Copy link
Member Author

Yeah, that's why I changed this to draft status, I saw that the tests failed and I didn't want to increase the rubocop version just for this of course. Thank you for disabling the cop for now, and feel free to close this if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants