Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: runoff sensitivities to pr and tas (WIP) #9

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

nocollier
Copy link
Contributor

@nocollier nocollier commented Aug 27, 2024

Implement work by Hanjun and Flavio.

Sensitivities are defined as the coefficients from a linear regression of the anomalies of mrro ~ tas + pr on a per basin basis.

To do

  • Port the methodology as an analysis type in the ilamb3 system. Numbers are approximately correct based on CanESM5/Amazon figure provided by Hanjun.
  • Validate ilamb3 sensitivities with precise numbers form Hanjun.
  • Add the MRB river basin regions to ILAMB-Data.
  • Provide documentation for the ilamb3 readthedocs site.
  • Decide on the form of the reference data. Do we store the sensitivities as a dataset or do we have the users provide reference sources for mrro, tas, and pr and compute them on the fly?
  • Decide on a transformation of the sensitivities of the reference and comparison into a score as per the ilamb paradigm.
  • Create tests which cover all of the new methodology.

Ideas

  • Create global maps of the sensitivities extended by their corresponding basins for the reference, comparison, and then bias.
  • Scoring provides an opportunity to think about how to use uncertainty from both the reference and the comparison

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0.51020% with 195 lines in your changes missing coverage. Please review.

Project coverage is 67.10%. Comparing base (273ea86) to head (eeace80).

Files with missing lines Patch % Lines
ilamb3/analysis/runoff_sensitivity.py 0.00% 125 Missing ⚠️
ilamb3/post.py 0.00% 63 Missing ⚠️
ilamb3/dataset.py 12.50% 7 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (273ea86) and HEAD (eeace80). Click for more details.

HEAD has 146 uploads less than BASE
Flag BASE (273ea86) HEAD (eeace80)
150 4
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #9       +/-   ##
===========================================
- Coverage   81.93%   67.10%   -14.84%     
===========================================
  Files          13       15        +2     
  Lines         880     1076      +196     
===========================================
+ Hits          721      722        +1     
- Misses        159      354      +195     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant