Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes issue #53 by creating convert file #68

Merged
merged 2 commits into from
Aug 20, 2024
Merged

closes issue #53 by creating convert file #68

merged 2 commits into from
Aug 20, 2024

Conversation

msteckle
Copy link
Collaborator

@msteckle msteckle commented Aug 15, 2024

Thank you for contributing to ILAMB-Data. Use this template when submitting a pull request.

🛠 Issue reference

Include a reference to the issue # here.
Added GIMMS LAI dataset from Cao 2023 per the issue #53

🧪 Testing

Add an x between the brackets to indicate basic testing was completed

  • I inspected the outputted NetCDF and checked for obvious errors
  • I visualized the outputted NetCDF at a timestamp to check for obvious visual errors
  • I compared my convert script to recent existing ones
  • I attempted to create/encode the NetCDF according to CF Compliance guidelines

🧪 (Optional) Preview

Attach an image of your dataset here
download

🏎 (Optional) Quality Checklist

Add an x between the brackets to indicate script quality adherence

  • There are no unused libraries imported into the code
  • There are no erroneous console logs, debuggers, or leftover testing code
  • There are no hard-coded paths to your local machine in the script
  • Useful headings describe sections of your code
  • Variable names are generalizable and easy to read

📏 (Optional) CF Compliance In-Depth Checklist

Add an x between the brackets to ensure CF compliance

Dimensions

  • Dimensions include time with attributes/encoding:
    • axis attribute is T
    • units attribute/encoding is days since YYYY-MM-DD HH:MM:SS
    • long_name attribute is time
    • calendar encoding is noleap
    • bounds encoding is time_bounds
  • Dimensions include lon with attributes:
    • axis attribute is X
    • units attribute is degrees_east
    • long_name attribute is longitude
  • Dimensions include lat with attributes:
    • axis attribute is Y
    • units attribute is degrees_north
    • long_name attribute is latitude
  • Dimensions include nv, which is an array of length 2 that contains the start date and end date bounding the dataset

Data Variables and their Attributes

  • The variable(s) for model comparison are present
    • the variables are linked to the time,lat, and lon dimensions
    • long_name attribute is specified
    • units attribute is specified
    • (If necessary) ancillary_variables attribute is specified if an uncertainty value is provided
    • (Optional) Float32 data type
    • (Optional) No-data values masked as NaN
  • If applicable, a data uncertainty variable is present (e.g., standard_deviation or standard_error)
    • the variable is linked to the time, lat, and lon dimensions
    • long_name attribute is specified (e.g., cSoil standard_deviation)
    • units attribute is specified; it is unitless, so it should be 1
  • A time_bounds variable is present
    • the variable is linked to the time and nv dimensions
    • long_name attribute is specified as time_bounds
    • units is encoded as days since YYYY-MM-DD HH:MM:SS

Global Attributes

  • 'title'
  • 'institution'
  • 'source'
  • 'history'
  • 'references'
    • @reference-type{ref-name, author={Last, First and}, title={}, journal={}, year={}, volume={}, pages={num--num}, doi={no-https}}
  • 'comment'
  • 'Conventions'

@msteckle msteckle linked an issue Aug 15, 2024 that may be closed by this pull request
@msteckle msteckle requested a review from nocollier August 15, 2024 20:13
@nocollier
Copy link
Collaborator

Can you try apply the scale factor you mentioned in chat? I am looking at:

https://www.ilamb.org/CMIP5v6/historical/EcosystemandCarbonCycle/LeafAreaIndex/AVHRR/AVHRR.html

and noticing that the ILAMB range plots 0-6 which would match perfectly. Seems likely they intend that.

Copy link
Collaborator

@nocollier nocollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my comment so I can submit the review 🤦🏻

@msteckle
Copy link
Collaborator Author

Can you try apply the scale factor you mentioned in chat? I am looking at:

https://www.ilamb.org/CMIP5v6/historical/EcosystemandCarbonCycle/LeafAreaIndex/AVHRR/AVHRR.html

and noticing that the ILAMB range plots 0-6 which would match perfectly. Seems likely they intend that.

Yes! Tada!
download

Copy link
Collaborator Author

@msteckle msteckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added conversion factor

@msteckle msteckle requested a review from nocollier August 19, 2024 18:43
@nocollier nocollier merged commit fcaf057 into master Aug 20, 2024
@nocollier
Copy link
Collaborator

Thank you! It strikes me that it would be good to create images like this in the data creation process. It let's you know how this new dataset relates to the other in our collection. I have code to do this but it should be rewritten and use our new database ideas instead. Just food for thought.

@nocollier nocollier deleted the 53-gimms-lai branch August 20, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

GIMMS lai
2 participants