Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RealSenseのcamera_namespace対応 #197

Merged
merged 1 commit into from
Jun 24, 2024
Merged

RealSenseのcamera_namespace対応 #197

merged 1 commit into from
Jun 24, 2024

Conversation

Kuwamai
Copy link
Contributor

@Kuwamai Kuwamai commented Jun 21, 2024

What does this implement/fix?

RealSenseのトピック名にcamera_namespaceが追加され、カメラサンプルが動作しない状態になっていたため修正しました。
既存のカメラサンプルには変更を加えず、camera_namespaceを空欄にすることで対応してます。

Does this close any currently open issues?

しません

How has this been tested?

点群等のトピックのnamespaceがcamera_namespace追加前と同じになることを確認しました。

# 修正前
/camera/camera/depth/color/points
# 修正後
/camera/depth/color/points

Any other comments?

Checklists

@Kuwamai Kuwamai added the Type: Bug Bug or Bug fixes label Jun 21, 2024
@Kuwamai Kuwamai requested a review from ShotaAk June 21, 2024 10:05
@Kuwamai Kuwamai self-assigned this Jun 21, 2024
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShotaAk ShotaAk merged commit 3aeed1c into ros2 Jun 24, 2024
2 checks passed
@ShotaAk ShotaAk deleted the fix_realsense_ns branch June 24, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants