Improve performance of vec_fmt_*() by not building the full data #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
force-pushed
the
plot-perf-follow
branch
from
58d2bb5 to
ca4b9af
Compare
|
Thank you! Will review this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By removing some unnecessary build stage operations, we are able to speed up significantly the rendering of the
vec_fmt_*()functions and hencecols_nanoplot().This seems to double speed by avoiding unnecessary operations!
Related GitHub Issues and PRs
vec_*()functions. #1888Checklist
testthatunit tests totests/testthatfor any new functionality.