Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift loglikelihood bugfixes #161

Merged
merged 67 commits into from
Oct 9, 2023
Merged

Shift loglikelihood bugfixes #161

merged 67 commits into from
Oct 9, 2023

Conversation

Neves-P
Copy link
Collaborator

@Neves-P Neves-P commented Oct 8, 2023

Still need to add patchnotes to NEWS.md. I'll try on Tuesday, but go ahead if you'd like to fill them in before.

@rsetienne rsetienne closed this Oct 8, 2023
@rsetienne rsetienne reopened this Oct 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #161 (560c371) into develop (ebf13e6) will decrease coverage by 1.43%.
Report is 3 commits behind head on develop.
The diff coverage is 73.80%.

❗ Current head 560c371 differs from pull request most recent head ca7cbb2. Consider uploading reports for the commit ca7cbb2 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #161      +/-   ##
===========================================
- Coverage    68.54%   67.11%   -1.43%     
===========================================
  Files           78       79       +1     
  Lines         7964     8123     +159     
===========================================
- Hits          5459     5452       -7     
- Misses        2505     2671     +166     
Files Coverage Δ
R/DAISIE_ML1.R 82.50% <100.00%> (-0.77%) ⬇️
R/DAISIE_ML_CS.R 41.26% <ø> (ø)
R/DAISIE_SR_loglik_CS.R 29.55% <100.00%> (-55.37%) ⬇️
R/DAISIE_loglik_CS.R 81.27% <100.00%> (-0.86%) ⬇️
R/DAISIE_utils.R 55.31% <ø> (ø)
R/create_pars.R 71.15% <ø> (ø)
R/DAISIE_loglik_integrate.R 88.41% <75.00%> (-0.48%) ⬇️
R/DAISIE_loglik_CS_shift.R 71.71% <71.71%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rsetienne rsetienne marked this pull request as ready for review October 9, 2023 10:56
@rsetienne rsetienne merged commit 79ff8b2 into develop Oct 9, 2023
15 checks passed
@rsetienne rsetienne deleted the shift_loglik branch October 9, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants