Sound player end notification now working

roymacdonald · Jul 19, 2023 · a8f50fb · a8f50fb
1 parent ebacf7b
commit a8f50fb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/ofxMultiSoundPlayer.cpp b/src/ofxMultiSoundPlayer.cpp
@@ -227,8 +227,9 @@ void ofxMultiSoundPlayer::setNumInstances(const size_t & num){
 	}
 
 }
-void ofxMultiSoundPlayer::onInstanceEnd(size_t&){
+void ofxMultiSoundPlayer::onInstanceEnd(size_t& i){
 	checkPaused();
+	ofNotifyEvent(endEvent, i, this);
 }
 //========================GETTERS===============================
 //--------------------------------------------------------------

diff --git a/src/ofxSingleSoundPlayer.cpp b/src/ofxSingleSoundPlayer.cpp
@@ -258,7 +258,8 @@ void ofxSingleSoundPlayer::stop(){
 //--------------------------------------------------------------
 void ofxSingleSoundPlayer::update(ofEventArgs&){
 	if(bNotifyEnd){
-		ofNotifyEvent(endEvent, _id, this);
+		auto i = _id;// make a copy so it is not possible to modify it through the callback, as it is passed by nonconst reference
+		ofNotifyEvent(endEvent, i, this);
 		bNotifyEnd = false;
 	}
 	if(bNeedsPreprocessBuffer){